Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include client framework versions in API requests #780

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Include client framework versions in API requests #780

merged 3 commits into from
Dec 4, 2023

Conversation

bkeepers
Copy link
Collaborator

@bkeepers bkeepers commented Dec 4, 2023

Sends Rails, Sinatra, and Hanami versions so we can prioritize which versions to support.

cc #776

jnunemaker
jnunemaker approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@jnunemaker jnunemaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

Only thing I’d maybe change is add rescue around the method and constants inside the block in case they change but I imagine they are pretty stable.

@bkeepers bkeepers merged commit 9e28949 into main Dec 4, 2023
64 checks passed
@bkeepers bkeepers deleted the client-frameworks branch December 4, 2023 22:55
@bkeepers bkeepers mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnunemaker jnunemaker jnunemaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkeepers @jnunemaker